amogh-jahagirdar commented on code in PR #13695:
URL: https://github.com/apache/iceberg/pull/13695#discussion_r2243714374
##########
api/src/main/java/org/apache/iceberg/Metrics.java:
##########
@@ -74,6 +77,25 @@ public Metrics(
this.upperBounds = upperBounds;
}
+ public Metrics(
+ Long rowCount,
+ Map<Integer, Long> columnSizes,
+ Map<Integer, Long> valueCounts,
+ Map<Integer, Long> nullValueCounts,
+ Map<Integer, Long> nanValueCounts,
+ Map<Integer, ByteBuffer> lowerBounds,
+ Map<Integer, ByteBuffer> upperBounds,
+ Map<Integer, Type> originalTypes) {
+ this.rowCount = rowCount;
+ this.columnSizes = columnSizes;
+ this.valueCounts = valueCounts;
+ this.nullValueCounts = nullValueCounts;
+ this.nanValueCounts = nanValueCounts;
+ this.lowerBounds = lowerBounds;
+ this.upperBounds = upperBounds;
+ this.originalTypes = originalTypes;
Review Comment:
Nit: Shall we update the existing constructors to call `this(...)` and pass
in nulls for the extraneous arguments?
##########
api/src/main/java/org/apache/iceberg/Metrics.java:
##########
@@ -74,6 +77,25 @@ public Metrics(
this.upperBounds = upperBounds;
}
+ public Metrics(
+ Long rowCount,
+ Map<Integer, Long> columnSizes,
+ Map<Integer, Long> valueCounts,
+ Map<Integer, Long> nullValueCounts,
+ Map<Integer, Long> nanValueCounts,
+ Map<Integer, ByteBuffer> lowerBounds,
+ Map<Integer, ByteBuffer> upperBounds,
+ Map<Integer, Type> originalTypes) {
+ this.rowCount = rowCount;
+ this.columnSizes = columnSizes;
+ this.valueCounts = valueCounts;
+ this.nullValueCounts = nullValueCounts;
+ this.nanValueCounts = nanValueCounts;
+ this.lowerBounds = lowerBounds;
+ this.upperBounds = upperBounds;
+ this.originalTypes = originalTypes;
Review Comment:
Nit: Shall we update the existing constructors to call `this(...)` and pass
in nulls for the extraneous arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
