amogh-jahagirdar commented on code in PR #13695:
URL: https://github.com/apache/iceberg/pull/13695#discussion_r2252714096


##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -151,6 +152,7 @@ public static class Builder {
     private Map<Integer, Long> nanValueCounts = null;
     private Map<Integer, ByteBuffer> lowerBounds = null;
     private Map<Integer, ByteBuffer> upperBounds = null;
+    private Map<Integer, Type> originalTypes = null;

Review Comment:
   Ok this makes sense to me now, I had missed for the DV case that the change 
to `FileMetadata` would already cover propagation of the types required for the 
future stats conversion (since we just copy over the fields from the metrics in 
the builder)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to