pvary commented on code in PR #13695:
URL: https://github.com/apache/iceberg/pull/13695#discussion_r2251647921
##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -151,6 +152,7 @@ public static class Builder {
private Map<Integer, Long> nanValueCounts = null;
private Map<Integer, ByteBuffer> lowerBounds = null;
private Map<Integer, ByteBuffer> upperBounds = null;
+ private Map<Integer, Type> originalTypes = null;
Review Comment:
Discussed with @nastra, to move the `Metrics.originalTypes()` to package
private. So we don't pollute the API with this method. This way we don't have
to describe the users when this field is available, and when it is not
available.
I think this is a good compromise, so we can proceed with implementing the
stats, and eventually deprecate the way to generate the stats from metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
