jackye1995 commented on a change in pull request #1754:
URL: https://github.com/apache/iceberg/pull/1754#discussion_r521813339
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputStream.java
##########
@@ -91,9 +104,36 @@ public void close() throws IOException {
try {
stream.close();
- s3.putObject(
-
PutObjectRequest.builder().bucket(location.bucket()).key(location.key()).build(),
- RequestBody.fromFile(stagingFile));
+ PutObjectRequest.Builder requestBuilder = PutObjectRequest.builder()
Review comment:
Ah sorry misread the question. Technically `super.close()` calls
`PositionOutputStream.close()` calls `OutputStream.close()` which does nothing,
so I think it is fine to not have it in the try block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
