danielcweeks commented on a change in pull request #1754:
URL: https://github.com/apache/iceberg/pull/1754#discussion_r523259908
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -73,4 +89,19 @@ private S3Client client() {
}
return client;
}
+
+ @Override
+ public void initialize(Map<String, String> properties) {
+ this.sseType = properties.getOrDefault(AwsCatalogProperties.S3_SSE_TYPE,
AwsCatalogProperties.S3_SSE_TYPE_NONE);
Review comment:
As mentioned in #1767, it would be nice to wrap these properties in
AwsCatalogProperties as a utility class and just keep reference to the
properties as opposed to enumerating them here an in BaseS3File.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
