danielcweeks commented on a change in pull request #1754:
URL: https://github.com/apache/iceberg/pull/1754#discussion_r524436394
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputFile.java
##########
@@ -29,7 +30,11 @@
public class S3OutputFile extends BaseS3File implements OutputFile {
public S3OutputFile(S3Client client, S3URI uri) {
- super(client, uri);
+ this(client, uri, AwsCatalogProperties.S3_SSE_TYPE_NONE, null, null);
+ }
+
+ public S3OutputFile(S3Client client, S3URI uri, String sseType, String
sseKey, String sseMd5) {
Review comment:
As I mentioned in the comment above, this is what I think we want to try
to avoid where we have to add constructor params per property we need to add.
There are already a few others we need to push through (multipart size, canned
acl, etc.). I think turning the `AwsProperties` into a wrapper would help as
we expand this functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
