nastra commented on code in PR #14767:
URL: https://github.com/apache/iceberg/pull/14767#discussion_r2671481659
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -151,6 +175,21 @@ private CloseableIterable<FileScanTask>
planTableScan(PlanTableScanRequest planT
this.planId = response.planId();
PlanStatus planStatus = response.planStatus();
+ List<Credential> storageCredentials = response.credentials();
Review Comment:
I don't think we would want to send the planId in the /credentials call,
because that ultimately means that we're using a separate FileIO object. If the
server doesn't send back credentials and we end up using the creds from the
table, then there's really no need to add the planId as additional context when
creds are being refreshed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
