nastra commented on code in PR #14767:
URL: https://github.com/apache/iceberg/pull/14767#discussion_r2671542643
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -151,6 +175,21 @@ private CloseableIterable<FileScanTask>
planTableScan(PlanTableScanRequest planT
this.planId = response.planId();
PlanStatus planStatus = response.planStatus();
+ List<Credential> storageCredentials = response.credentials();
+ if (null != planId && !response.credentials().isEmpty()) {
+ this.fileIOForPlanId =
+ CatalogUtil.loadFileIO(
+ FILE_IO_IMPL,
+ ImmutableMap.<String, String>builder()
+ .putAll(catalogProperties)
+ .put(RESTCatalogProperties.REST_SCAN_PLAN_ID, planId)
+ .buildKeepingLast(),
+ hadoopConf,
+ storageCredentials.stream()
+ .map(c -> StorageCredential.create(c.prefix(), c.config()))
Review Comment:
you mean adding the `credentials` to `FetchPlanningResultResponse`? This
makes sense and apologies for not catching that myself. I was misinterpreting
the spec due to all the different layers of objects that we have there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
