singhpk234 commented on code in PR #14767:
URL: https://github.com/apache/iceberg/pull/14767#discussion_r2674147131
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -151,6 +175,21 @@ private CloseableIterable<FileScanTask>
planTableScan(PlanTableScanRequest planT
this.planId = response.planId();
PlanStatus planStatus = response.planStatus();
+ List<Credential> storageCredentials = response.credentials();
Review Comment:
the way i see is plan-id being an additional context being sent from client
to server to mark that this credentials is being requested in context of an
active scan plan, using plan-id to return one use case, users may add plan-id
in their sesssion tag too just for audit pov
https://github.com/apache/iceberg/blob/0094ccc0aeec33638f34ff5c4074b4cfe4bdf58c/open-api/rest-catalog-open-api.yaml#L1224
we don't specifically say that we give creds corresponding to plan-id, we
just pass it along as context, so IMHO if we have this context we should pass
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
