nastra opened a new pull request, #15010: URL: https://github.com/apache/iceberg/pull/15010
This was already working for all catalogs that support views, except for the `HiveCatalog`. All catalogs already had some logic that would perform table/view conflict detection when committing metadata in their `doCommit()` methods. However, the `HiveCatalog` currently does view/table detection one step earlier, namely when `doRefresh()` is called in https://github.com/apache/iceberg/blob/cbd35799dc70e989528b1c14d640fe91cdafa52d/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L175-L177. It probably doesn't hurt to override `registerTable()` for view catalgos and add early view detection (before metadata is actually committed). fixes #15009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
