pvary commented on code in PR #15010:
URL: https://github.com/apache/iceberg/pull/15010#discussion_r2685929836
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -911,4 +911,37 @@ public View create() {
return super.create();
}
}
+
+ /**
+ * Register a table with the catalog if it does not exist. This is
overridden in order to add view
+ * existence detection before registering a table.
+ *
+ * @param identifier a table identifier
+ * @param metadataFileLocation the location of a metadata file
+ * @return a Table instance
+ * @throws org.apache.iceberg.exceptions.AlreadyExistsException if a table
or view with the same
Review Comment:
Should we change the import from
`org.apache.hadoop.hive.metastore.api.AlreadyExistsException` to
`org.apache.iceberg.exceptions.AlreadyExistsException`. This would allow us to
simplify the code so many places. The hive exception is used only once.
Don't have very strong feelings around this, but we add 3 more instances of
full class name usage here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
