nastra commented on PR #15010: URL: https://github.com/apache/iceberg/pull/15010#issuecomment-3743623402
> I see that the goal here is to have the same validation logic for every catalog. I understand that this is quick solution to the problem, but maybe an alternative solution could help alleviate more of the future issues. Could we just put the validation logic to the `BaseMetastoreViewCatalog` and use it everywhere? Would this be too costly to refactor? Moving the detection logic into `BaseMetastoreViewCatalog` is what I originally had it but pretty much all catalogs already worked anyway so I moved it to the Hive catalog only. The other issue was that it would also require overriding table registration in the `JDBCCatalog` in order to detect whether view support is available or not (this is because the JDBC catalog has a separate flag to add view support and runs by default without view support). Hence it's probably best to only override table registration in the `HiveCatalog` but I'm open to changing this if people thing it's better to move the detection logic into `BaseMetastoreViewCatalog`. wdyt @pvary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
