danielcweeks commented on code in PR #15184:
URL: https://github.com/apache/iceberg/pull/15184#discussion_r2755597775
##########
core/src/main/java/org/apache/iceberg/SupportsDistributedScanPlanning.java:
##########
@@ -18,5 +18,9 @@
*/
package org.apache.iceberg;
-/** Marker interface to indicate whether a Table requires remote scan planning
*/
-public interface RequiresRemoteScanPlanning {}
+/** Marker interface to indicate whether a Table supports distributed scan
planning */
Review Comment:
Part of the move away from "RemoteScanPlanning" as the marker is that remote
planning is a REST specific concept and distributed planning is a general
concept. I'd prefer that we don't leak REST concepts throughout the API
surface area.
Also, I don't think there's an issue with providing an interface that
exposes multiple options. We don't want the interface to necessarily force a
behavior (e.g. `Requires` something) because then you can't support multiple
options. Some markers just indicate that a thing can be done, but in this case
we want the implementation to be able to make a determination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
