singhpk234 commented on code in PR #15184:
URL: https://github.com/apache/iceberg/pull/15184#discussion_r2770253927
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -291,8 +292,15 @@ public int parallelism() {
return Math.max(defaultParallelism, numShufflePartitions);
}
+ public boolean distributedPlanningDisallowed() {
+ return table instanceof SupportsDistributedScanPlanning distributed
+ && !distributed.allowDistributedPlanning();
+ }
+
public boolean distributedPlanningEnabled() {
- return dataPlanningMode() != LOCAL || deletePlanningMode() != LOCAL;
+ return table instanceof SupportsDistributedScanPlanning distributed
+ && distributed.allowDistributedPlanning()
+ && (dataPlanningMode() != LOCAL || deletePlanningMode() != LOCAL);
Review Comment:
[not scope of this change] should we change the spark docs for this
https://iceberg.apache.org/docs/nightly/spark-configuration/#spark-sql-options
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -291,8 +292,15 @@ public int parallelism() {
return Math.max(defaultParallelism, numShufflePartitions);
}
+ public boolean distributedPlanningDisallowed() {
+ return table instanceof SupportsDistributedScanPlanning distributed
+ && !distributed.allowDistributedPlanning();
+ }
Review Comment:
minor: It might be contradictory to see we have
`distributedPlanningDisallowed` not an exact negation of
`distributedPlanningEnabled` ?
How about we name this : `underlyingTableSupportsDistributedPlanning()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
