nastra commented on code in PR #15184:
URL: https://github.com/apache/iceberg/pull/15184#discussion_r2793916892
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -761,9 +760,9 @@ public StructType readSchema() {
}
private BatchScan newBatchScan() {
- if (table instanceof RequiresRemoteScanPlanning) {
+ if (readConf.distributedPlanningDisallowed()) {
return table.newBatchScan();
- } else if (table instanceof BaseTable &&
readConf.distributedPlanningEnabled()) {
+ } else if (readConf.distributedPlanningEnabled()) {
Review Comment:
I think it would be a little bit weird to pass the table, given that the
config already has access to the table. However, I've made another
simplification so that we don't actually need
`distributedPlanningDisallowed()`. Having `distributedPlanningEnabled()` is
enough and achieves the same thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
