nastra commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2757827156
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -304,6 +302,7 @@ public void createCatalog() throws Exception {
@Override
protected RESTCatalog initCatalog(String catalogName, Map<String, String>
additionalProperties) {
+ File warehouse = temp.toFile();
Review Comment:
```
File warehouse = temp.toFile();
backendCatalog.initialize(
"in-memory",
ImmutableMap.<String, String>builder()
.put(CatalogProperties.WAREHOUSE_LOCATION,
warehouse.getAbsolutePath())
.putAll(additionalProperties)
.build());
```
this should be enough. I don't think we need any of the special handling
further below, so we can remove `BACKEND_PROPS` and revert all of the changes
further down in `initCatalog`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
