rdblue commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2843301905
##########
api/src/main/java/org/apache/iceberg/expressions/Expressions.java:
##########
@@ -202,6 +204,24 @@ public static UnboundPredicate<String>
notStartsWith(UnboundTerm<String> expr, S
return new UnboundPredicate<>(Expression.Operation.NOT_STARTS_WITH, expr,
value);
}
+ public static UnboundPredicate<ByteBuffer> stIntersects(String name,
BoundingBox value) {
Review Comment:
I think I'm fine either way. We could include an override here that produces
a bounding box. I agree with not having 6 and 8 argument versions of the
method. And we will need to consider what to name the factory methods in
`BoundingBox` because it can be ambiguous whether you're passing z or m through
a 6-arg factory method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
