rdblue commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2843295145
##########
api/src/main/java/org/apache/iceberg/expressions/Literals.java:
##########
@@ -719,4 +723,71 @@ public String toString() {
return "X'" + BaseEncoding.base16().encode(bytes) + "'";
}
}
+
+ static class BoundingBoxLiteral implements Literal<ByteBuffer> {
Review Comment:
I don't think this requires breaking constraints for `UnboundPredicate`.
Those constraints are not violated:
* `T` is a type held by a literal, in this case `BoundingBox`
* `Literal<T>` is a literal that holds that type, which is
`Literal<BoundingBox>` implemented by `BoundingBoxLiteral`
* `List<Literal<T>>` is a holder in case the unbound expression has multiple
literals. It won't in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
