rdblue commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2843280585
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java:
##########
@@ -166,6 +178,12 @@ public <T> R predicate(BoundPredicate<T> pred) {
return startsWith((BoundReference<T>) pred.term(),
literalPred.literal());
case NOT_STARTS_WITH:
return notStartsWith((BoundReference<T>) pred.term(),
literalPred.literal());
+ case ST_INTERSECTS:
+ return stIntersects(
+ (BoundReference<T>) pred.term(), (Literal<ByteBuffer>)
literalPred.literal());
Review Comment:
Yes, we may still need to do an unchecked cast. This is an odd situation
where the literal and term don't produce the same thing. I would rather have an
unchecked cast here and pass `BoundingBox` than try to make everything work as
`ByteBuffer`, where the Java type matches but the actual values are completely
different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
