RussellSpitzer commented on code in PR #15656:
URL: https://github.com/apache/iceberg/pull/15656#discussion_r2943744681
##########
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##########
@@ -310,9 +311,34 @@ public static List<DataFile> newFiles(
return newFiles;
}
+ /**
+ * @deprecated will be removed in 1.12.0, use {@link SnapshotChanges} with
{@link
+ * #ancestorsBetween(long, Long, Function)} instead.
+ */
+ @Deprecated
public static CloseableIterable<DataFile> newFilesBetween(
Long startSnapshotId, long endSnapshotId, Function<Long, Snapshot>
lookup, FileIO io) {
+ List<Snapshot> snapshots = snapshotsBetween(startSnapshotId,
endSnapshotId, lookup);
+ return new ParallelIterable<>(
+ Iterables.transform(snapshots, snapshot ->
snapshot.addedDataFiles(io)),
+ ThreadPools.getWorkerPool());
+ }
+ /**
+ * @deprecated will be removed in 1.12.0, use {@link SnapshotChanges} with
{@link
+ * #ancestorsBetween(long, Long, Function)} instead.
+ */
+ @Deprecated
+ public static CloseableIterable<DataFile> newFilesBetween(
Review Comment:
Wait a second on reviewing this. I'm about to back out this change for
something a bit simpler. Sorry I was having some post dinner thoughts and now I
need to change some things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
