RussellSpitzer commented on code in PR #15656:
URL: https://github.com/apache/iceberg/pull/15656#discussion_r2943794566


##########
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##########
@@ -310,6 +311,11 @@ public static List<DataFile> newFiles(
     return newFiles;
   }
 
+  /**
+   * @deprecated will be removed in 1.12.0, use {@link SnapshotChanges} with 
{@link
+   *     #ancestorsBetween(long, Long, Function)} instead.
+   */
+  @Deprecated
   public static CloseableIterable<DataFile> newFilesBetween(

Review Comment:
   Instead of fixing this method or changing Snapshot Changes right now for new 
streaming functionality, i just put it directly into 
CherryPickOperation.validateReplacedPartitions. It was the only caller and I 
want to add this capability to SnapshotChanges in the future. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to