RussellSpitzer commented on code in PR #15656: URL: https://github.com/apache/iceberg/pull/15656#discussion_r2943747937
########## spark/v3.4/spark/src/jmh/java/org/apache/iceberg/spark/source/parquet/IcebergSourceParquetMultiDeleteFileBenchmark.java: ########## @@ -21,15 +21,16 @@ import java.io.IOException; import org.apache.iceberg.DataFile; import org.apache.iceberg.FileFormat; +import org.apache.iceberg.SnapshotChanges; import org.apache.iceberg.spark.source.IcebergSourceDeleteBenchmark; import org.openjdk.jmh.annotations.Param; /** * A benchmark that evaluates the non-vectorized read and vectorized read with pos-delete in the * Spark data source for Iceberg. * - * <p>This class uses a dataset with a flat schema. To run this benchmark for spark-3.4: <code> - * ./gradlew -DsparkVersions=3.4 :iceberg-spark:iceberg-spark-3.4:jmh \ + * <p>This class uses a dataset with a flat schema. To run this benchmark for spark-4.1: <code> Review Comment: We don't have a 3.4 module anymore, so this was technically impossible :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
