Guosmilesmile commented on code in PR #15675:
URL: https://github.com/apache/iceberg/pull/15675#discussion_r2982109955
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -719,4 +1205,15 @@ private static String splitSizeProperty(FileFormat
fileFormat) {
"No split size property defined for format: " + fileFormat);
};
}
+
+ private Map<Integer, Object> convertConstantsToEngine(
Review Comment:
Sorry, I'm not quite able to get the direction of the adjustment needed
here. However, I have made some changes mentioned above, and I'm not sure if
further adjustments are needed in this part. I would appreciate more
suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
