pvary commented on code in PR #15675:
URL: https://github.com/apache/iceberg/pull/15675#discussion_r2982912643
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -204,7 +213,8 @@ void testDataWriterGenericWriteEngineRead(FileFormat
fileFormat, DataGenerator d
readRecords = ImmutableList.copyOf(reader);
}
- assertEquals(schema, convertToEngineRecords(genericRecords, schema),
readRecords);
+ List<T> list = convertToEngineRecords(genericRecords, schema);
+ assertEquals(schema, list, readRecords);
Review Comment:
You promised to revert this back, but seems like it slipped somehow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
