rambleraptor commented on code in PR #15746:
URL: https://github.com/apache/iceberg/pull/15746#discussion_r2983192006
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -162,6 +162,8 @@ paths:
$ref: '#/components/responses/UnauthorizedResponse'
403:
$ref: '#/components/responses/ForbiddenResponse'
+ 404:
+ $ref: '#/components/responses/NoSuchWarehouseResponse'
Review Comment:
I'm personally a fan of not adding new response types.
We expect tools/libraries to be checking against the HTTP status codes when
response parsing. But, if they're checking against the type, then those tools
need to be updated to understand this new WarehouseNotFound exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
