oguzhanunlu commented on code in PR #15746:
URL: https://github.com/apache/iceberg/pull/15746#discussion_r2991090880
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -162,6 +162,8 @@ paths:
$ref: '#/components/responses/UnauthorizedResponse'
403:
$ref: '#/components/responses/ForbiddenResponse'
+ 404:
+ $ref: '#/components/responses/NoSuchWarehouseResponse'
Review Comment:
@rdblue Thanks for the feedback. I've pushed a new commit to follow the
inline pattern you shared.
On status code choice, let me share that Apache Polaris
[throws](https://github.com/apache/polaris/blob/main/runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java#L1360)
`NotFoundException` which gets
[mapped](https://github.com/apache/polaris/blob/main/runtime/service/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java#L174)
to 404 when the warehouse doesn't exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
