singhpk234 commented on code in PR #15242:
URL: https://github.com/apache/iceberg/pull/15242#discussion_r2985981941
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3MultipartUpload.java:
##########
@@ -141,6 +145,34 @@ public void testParallelUpload() throws IOException {
}
}
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ public void testMultipartUploadWithChunkedEncoding(boolean
chunkedEncodingEnabled)
+ throws IOException {
+ // Create a new S3FileIO with specified chunked encoding setting
+ S3FileIO testIo = new S3FileIO(() -> s3);
Review Comment:
can we wrap with try-with resource , so the testIO is closed ?
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -295,6 +295,18 @@ public class S3FileIOProperties implements Serializable {
public static final boolean REMOTE_SIGNING_ENABLED_DEFAULT = false;
+ /**
+ * Enables or disables chunked encoding for S3 requests.
+ *
+ * <p>This feature is disabled by default.
+ *
+ * <p>For more details see:
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/S3Configuration.html#chunkedEncodingEnabled()
+ */
+ public static final String CHUNKED_ENCODING_ENABLED =
"s3.chunked-encoding-enabled";
+
+ public static final boolean CHUNKED_ENCODING_ENABLED_DEFAULT = false;
Review Comment:
sorry for the last moment, seems like SDK default is true ? if yes this
might be different than what we have been doing so far ? i wonder if we should
just pass it to builder if the above propery is not empty and not have defaults
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
