plusplusjiajia commented on code in PR #15242:
URL: https://github.com/apache/iceberg/pull/15242#discussion_r2996231086
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3MultipartUpload.java:
##########
@@ -141,6 +145,34 @@ public void testParallelUpload() throws IOException {
}
}
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ public void testMultipartUploadWithChunkedEncoding(boolean
chunkedEncodingEnabled)
+ throws IOException {
+ // Create a new S3FileIO with specified chunked encoding setting
+ S3FileIO testIo = new S3FileIO(() -> s3);
Review Comment:
> can we wrap with try-with resource , so the testIO is closed ?
Thanks for the catch! Updated to use try-with-resources to ensure testIo is
properly closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
