steveloughran commented on code in PR #15242:
URL: https://github.com/apache/iceberg/pull/15242#discussion_r2987225841
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -295,6 +295,18 @@ public class S3FileIOProperties implements Serializable {
public static final boolean REMOTE_SIGNING_ENABLED_DEFAULT = false;
+ /**
+ * Enables or disables chunked encoding for S3 requests.
+ *
+ * <p>This feature is disabled by default.
+ *
+ * <p>For more details see:
+ *
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/s3/S3Configuration.html#chunkedEncodingEnabled()
+ */
+ public static final String CHUNKED_ENCODING_ENABLED =
"s3.chunked-encoding-enabled";
+
+ public static final boolean CHUNKED_ENCODING_ENABLED_DEFAULT = false;
Review Comment:
@singhpk234 the `CatalogSigner` doesn't sign chunked encoding
L255
```
if (signerParams.enableChunkedEncoding()) {
throw new UnsupportedOperationException("Chunked encoding not
supported");
}
```
Setting it to false ensures that if a client is using it to sign for uploads
(polaris are working on/have done that) then the requests are being signed.
It's likely a failure condition which hasn't *yet* been encountered
@adutra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
