anuragmantri commented on code in PR #15700:
URL: https://github.com/apache/iceberg/pull/15700#discussion_r3066828959
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -652,6 +666,8 @@ static Context deleteContext(Map<String, String> config) {
config, DELETE_PARQUET_DICT_SIZE_BYTES,
dataContext.dictionaryPageSize());
Preconditions.checkArgument(dictionaryPageSize > 0, "Dictionary page
size must be > 0");
+ WriterVersion writerVersion = dataContext.writerVersion();
Review Comment:
For consistency with other properties and the flexibility to use different
versions of parquet for deletes, we should probably use a different property
here.
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -135,6 +135,9 @@ private TableProperties() {}
"write.delete.parquet.page-size-bytes";
public static final int PARQUET_PAGE_SIZE_BYTES_DEFAULT = 1024 * 1024; // 1
MB
+ public static final String PARQUET_PAGE_VERSION =
"write.parquet.page-version";
+ public static final String PARQUET_PAGE_VERSION_DEFAULT = "1";
Review Comment:
We should also probably add this for deletes and use this when deletes are
needed
`public static final String DELETE_PARQUET_PAGE_VERSION =
"write.delete.parquet.page-version"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
