alliasgher commented on code in PR #875:
URL: https://github.com/apache/iceberg-go/pull/875#discussion_r3074413418
##########
table/internal/utils.go:
##########
@@ -236,7 +236,7 @@ func (d *DataFileStatistics) PartitionValue(field
iceberg.PartitionField, sc *ic
return lowerT.Val.Any()
}
-func (d *DataFileStatistics) ToDataFile(schema *iceberg.Schema, spec
iceberg.PartitionSpec, path string, format iceberg.FileFormat, content
iceberg.ManifestEntryContent, filesize int64, partitionValues map[int]any)
iceberg.DataFile {
+func (d *DataFileStatistics) ToDataFile(schema *iceberg.Schema, spec
iceberg.PartitionSpec, path string, format iceberg.FileFormat, content
iceberg.ManifestEntryContent, filesize int64, partitionValues map[int]any,
sortOrderID int) iceberg.DataFile {
Review Comment:
Agreed — will clean this up in a follow-up PR rather than widen the scope of
this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
