alliasgher commented on code in PR #875:
URL: https://github.com/apache/iceberg-go/pull/875#discussion_r3075222388
##########
table/internal/parquet_files_test.go:
##########
@@ -261,7 +261,7 @@ func TestMetricsPrimitiveTypes(t *testing.T) {
stats := format.DataFileStatsFromMeta(internal.Metadata(meta),
getCollector(), mapping)
df := stats.ToDataFile(tblMeta.CurrentSchema(),
tblMeta.PartitionSpec(), "fake-path.parquet",
- iceberg.ParquetFile, iceberg.EntryContentData,
meta.GetSourceFileSize(), nil)
+ iceberg.ParquetFile, iceberg.EntryContentData,
meta.GetSourceFileSize(), nil, 0)
Review Comment:
Added in 0015b1f — `TestMetricsPrimitiveTypes` now uses a non-zero sort
order id (7) and asserts the resulting DataFile carries it.
##########
table/pos_delete_partitioned_fanout_writer_test.go:
##########
@@ -503,7 +503,125 @@ func (m *dataFileMatcher) Format(val iceberg.DataFile)
string {
}
// defaultPositionDeleteMatching is a convenience preset for the options we
want to match for position delete matching
-var defaultPositionDeleteMatching =
[]dataFileMatcherOption{withContentTypeMatching(), withColumnSizesMatching(),
withCountMatching(), withFileFormatMatching(), withSpecIDMatching(),
withPartitionMatching(), withCountMatching()}
+var defaultPositionDeleteMatching =
[]dataFileMatcherOption{withContentTypeMatching(), withColumnSizesMatching(),
withCountMatching(), withFileFormatMatching(), withSpecIDMatching(),
withPartitionMatching(), withCountMatching(), withSortOrderIDMatching()}
+
+func intPtr(i int) *int { return &i }
Review Comment:
Replaced with a generic `ptr[T any]` in 0015b1f. There's one in
`snapshots_test.go` but it's scoped to `package table_test` (external) whereas
this file is in `package table` (internal), so I added a local generic helper.
Happy to consolidate further if you'd prefer moving the helper elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
