zeroshade commented on code in PR #875:
URL: https://github.com/apache/iceberg-go/pull/875#discussion_r3075152723
##########
table/pos_delete_partitioned_fanout_writer_test.go:
##########
@@ -503,7 +503,125 @@ func (m *dataFileMatcher) Format(val iceberg.DataFile)
string {
}
// defaultPositionDeleteMatching is a convenience preset for the options we
want to match for position delete matching
-var defaultPositionDeleteMatching =
[]dataFileMatcherOption{withContentTypeMatching(), withColumnSizesMatching(),
withCountMatching(), withFileFormatMatching(), withSpecIDMatching(),
withPartitionMatching(), withCountMatching()}
+var defaultPositionDeleteMatching =
[]dataFileMatcherOption{withContentTypeMatching(), withColumnSizesMatching(),
withCountMatching(), withFileFormatMatching(), withSpecIDMatching(),
withPartitionMatching(), withCountMatching(), withSortOrderIDMatching()}
+
+func intPtr(i int) *int { return &i }
Review Comment:
Don't we have a generic helper function for this somewhere? If not, can you
convert this to be a generic one?
```go
func ptrOf[T any](i T) *T { return &i }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
