pvary commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3100050373
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecord.java:
##########
@@ -38,6 +40,7 @@ public class DynamicRecord {
private int writeParallelism;
private boolean upsertMode;
@Nullable private Set<String> equalityFields;
+ @Nullable private FlinkWriteConf flinkWriteConf;
Review Comment:
Also, this is not serialized, this is just a temp override when reading?
Could it be that we create a DynamicRecordWithDefault class like this:
```
private class DynamicRecordWithDefault extends DynamicRecord {
private final FlinkWriteConf flinkWriteConf;
private DynamicRecord wrapped;
private DynamicRecord wrap(DynamicRecord newWrapped) {
this.wrapped = newWrapped;
}
[..]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
