pvary commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3100080753
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicTableUpdateOperator.java:
##########
@@ -49,19 +49,17 @@ class DynamicTableUpdateOperator
DynamicTableUpdateOperator(
CatalogLoader catalogLoader,
- int cacheMaximumSize,
- long cacheRefreshMs,
- int inputSchemasPerTableCacheMaximumSize,
TableCreator tableCreator,
- boolean caseSensitive,
- boolean dropUnusedColumns) {
+ FlinkDynamicSinkConf flinkDynamicSinkConf) {
Review Comment:
The name could be shorter, like `conf` or `configuration`. You don't need
the type name in the variable/parameter names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
