pvary commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3100103354
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java:
##########
@@ -1422,9 +1498,12 @@ private void verifyResults(List<DynamicIcebergDataImpl>
dynamicData) throws IOEx
dynamicData.forEach(
r -> {
+ String branch =
+ MoreObjects.firstNonNull(
+ r.branch,
writeProperties.get(FlinkWriteOptions.BRANCH.key()));
Review Comment:
I don't like that we use `firstNonNull` when we are only using 2 attributes.
We simply could use if, or `?` to archive the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
