evindj commented on code in PR #589:
URL: https://github.com/apache/iceberg-cpp/pull/589#discussion_r3102584605
##########
src/iceberg/table_scan.h:
##########
@@ -148,8 +151,12 @@ class ICEBERG_EXPORT TableScanBuilder : public
ErrorCollector {
/// \brief Constructs a TableScanBuilder for the given table.
/// \param metadata Current table metadata.
/// \param io FileIO instance for reading manifests files.
+ /// \param reporter Optional metrics reporter for scan metrics.
+ /// \param table_name Optional table name for metrics reporting.
static Result<std::unique_ptr<TableScanBuilder<ScanType>>> Make(
Review Comment:
good catch will address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
