Guosmilesmile commented on code in PR #16011:
URL: https://github.com/apache/iceberg/pull/16011#discussion_r3115263809
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java:
##########
@@ -105,8 +141,8 @@ public void prepareSnapshotPreBarrier(long checkpointId)
throws IOException {
new DynamicCommittable(
entries.getKey(),
writeToManifests(entries.getKey().tableName(),
entries.getValue(), checkpointId),
- getContainingTask().getEnvironment().getJobID().toString(),
- getRuntimeContext().getOperatorUniqueID(),
+ flinkJobId,
Review Comment:
I found similar logic in SinkV1 for deduplication based on job-id
transformation, but I didn't see the related logic in SinkV2. Just like the
dynamic sink, it directly obtains a new job-id.
https://github.com/apache/iceberg/blob/bbd121220a79baa18f305a3666530db32065f614/flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java#L111-L117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
