lrsb commented on code in PR #16011:
URL: https://github.com/apache/iceberg/pull/16011#discussion_r3124536729
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -119,28 +119,28 @@ public void
commit(Collection<CommitRequest<DynamicCommittable>> commitRequests)
DynamicWriteResultAggregator. Iceberg 1.12 will remove this, and users
should upgrade to the 1.11 release first
to migrate their state to a single commit request per checkpoint.
*/
- Map<TableKey, NavigableMap<Long, List<CommitRequest<DynamicCommittable>>>>
commitRequestMap =
- Maps.newHashMap();
+ Map<CommitGroupKey, NavigableMap<Long,
List<CommitRequest<DynamicCommittable>>>>
Review Comment:
Two cases:
1. Old-jobId snapshot already in the ancestor chain (normal replay after a
successful-but-unacked commit): old-jobId group's walk finds its own snapshot
and skips. New-jobId group commits fresh. This is what the tests cover.
2. Old-jobId snapshot not yet committed (crash before commit): both groups
have uncommitted work. Each is processed independently against the ancestor
chain and each produces a snapshot. No data duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
