yadavay-amzn commented on code in PR #16073:
URL: https://github.com/apache/iceberg/pull/16073#discussion_r3121047749
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -356,8 +356,13 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
.build());
LOG.info("Successfully dropped table {} from Glue", identifier);
if (purge && lastMetadata != null) {
- CatalogUtil.dropTableData(ops.io(), lastMetadata);
- LOG.info("Glue table {} data purged", identifier);
+ try {
+ CatalogUtil.dropTableData(ops.io(), lastMetadata);
+ LOG.info("Glue table {} data purged", identifier);
Review Comment:
The location could be checked for S3 Table Bucket ARN patterns, but catching
the exception is more robust as it handles any case where purge fails
(permissions, bucket policies, etc.) without needing to enumerate all possible
URI formats.
Looks like this also aligns with the Trino approach you linked!
Happy to add a URI check if you'd prefer a more targeted approach though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
