yadavay-amzn commented on code in PR #16073:
URL: https://github.com/apache/iceberg/pull/16073#discussion_r3140879714
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -356,8 +356,13 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
.build());
LOG.info("Successfully dropped table {} from Glue", identifier);
if (purge && lastMetadata != null) {
- CatalogUtil.dropTableData(ops.io(), lastMetadata);
- LOG.info("Glue table {} data purged", identifier);
+ try {
+ CatalogUtil.dropTableData(ops.io(), lastMetadata);
+ LOG.info("Glue table {} data purged", identifier);
+ } catch (Exception e) {
Review Comment:
Fair point — two reviewers have raised this now. What exception type would
you prefer here? The challenge is that `CatalogUtil.dropTableData` delegates to
different IO implementations (S3, GCS, HDFS) which throw different exception
types. Would `RuntimeException` be narrow enough, or would you prefer something
S3-specific like `SdkServiceException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
