yadavay-amzn commented on code in PR #16073:
URL: https://github.com/apache/iceberg/pull/16073#discussion_r3140883813
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -356,8 +356,13 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
.build());
LOG.info("Successfully dropped table {} from Glue", identifier);
if (purge && lastMetadata != null) {
- CatalogUtil.dropTableData(ops.io(), lastMetadata);
Review Comment:
Good point about S3 Tables purging behind the scenes. The current fix only
affects the `purge=true` path — when `purge=false`, `dropTableData` is never
called so there's no change in behavior. But I agree the broader S3 Tables
story may need more thought beyond this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
