RussellSpitzer commented on code in PR #16024:
URL: https://github.com/apache/iceberg/pull/16024#discussion_r3164240426
##########
core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponse.java:
##########
@@ -31,17 +31,20 @@
public class FetchPlanningResultResponse extends BaseScanTaskResponse {
private final PlanStatus planStatus;
+ private final ErrorResponse errorResponse;
private final List<Credential> credentials;
private FetchPlanningResultResponse(
PlanStatus planStatus,
+ ErrorResponse errorResponse,
List<String> planTasks,
List<FileScanTask> fileScanTasks,
List<DeleteFile> deleteFiles,
Map<Integer, PartitionSpec> specsById,
List<Credential> credentials) {
super(planTasks, fileScanTasks, deleteFiles, specsById);
this.planStatus = planStatus;
+ this.errorResponse = errorResponse;
this.credentials = credentials;
validate();
Review Comment:
Similar comment for validate,
error message must be null if we have a success etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
