RussellSpitzer commented on code in PR #16024:
URL: https://github.com/apache/iceberg/pull/16024#discussion_r3164251834
##########
core/src/main/java/org/apache/iceberg/rest/responses/PlanTableScanResponseParser.java:
##########
@@ -98,6 +103,11 @@ public static PlanTableScanResponse fromJson(
"Cannot parse planTableScan response from empty or null object");
PlanStatus planStatus = PlanStatus.fromName(JsonUtil.getString(STATUS,
json));
+ ErrorResponse errorResponse = null;
+ if (json.has(ERROR) && json.get(ERROR).isObject()) {
Review Comment:
I'm ok here, but do we want to change the validate method? Like should we
blow up if there is an ERROR but the response is not failed? Or other things
like that. I'm ok if we want to accept things which aren't up to spec but we
definitely should forbid producing new objects which don't match the spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
