stevenzwu commented on code in PR #16024:
URL: https://github.com/apache/iceberg/pull/16024#discussion_r3175168871
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -314,6 +315,21 @@ private CloseableIterable<FileScanTask>
fetchPlanningResult() {
return scanTasksIterable(response.planTasks(), response.fileScanTasks());
}
+ private static String failureMessage(PlanStatus status, String planId,
ErrorResponse error) {
+ if (error == null) {
Review Comment:
I am wondering if error should be required to be null when this method is
called? basically, this method is only called for the `FAILED` case.
maybe the CANCELLED case can use a separate code path and directly construct
the error msg for the IllegalStateException in line 293 above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
