RussellSpitzer commented on code in PR #16088:
URL: https://github.com/apache/iceberg/pull/16088#discussion_r3230113269
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -369,8 +369,19 @@ public CustomMetric[] supportedCustomMetrics() {
protected long adjustSplitSize(List<? extends ScanTask> tasks, long
splitSize) {
if (readConf.splitSizeOption() == null &&
readConf.adaptiveSplitSizeEnabled()) {
long scanSize = tasks.stream().mapToLong(ScanTask::sizeBytes).sum();
- int parallelism = readConf.parallelism();
- return TableScanUtil.adjustSplitSize(scanSize, parallelism, splitSize);
+ Integer configuredParallelism = readConf.splitParallelism();
+ int parallelism =
Review Comment:
Why is this logic here and not in SparkReadConf? Just seems like if we
wanted the default to be parallelism() we would just fall back in the
SparkReadConf class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
