RussellSpitzer commented on code in PR #16088:
URL: https://github.com/apache/iceberg/pull/16088#discussion_r3238336323
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##########
@@ -110,6 +110,14 @@ private SparkSQLProperties() {}
// Prefix for custom snapshot properties
public static final String SNAPSHOT_PROPERTY_PREFIX =
"spark.sql.iceberg.snapshot-property.";
+ // Controls whether adaptive split sizing is enabled
+ public static final String READ_ADAPTIVE_SPLIT_SIZE_ENABLED =
+ "spark.sql.iceberg.read.adaptive-split-size.enabled";
+
+ // Overrides the parallelism used for adaptive split sizing. When unset, the
parallelism
+ // defaults to max(spark.default.parallelism, spark.sql.shuffle.partitions).
+ public static final String READ_SPLIT_PARALLELISM =
"spark.sql.iceberg.read.split-parallelism";
Review Comment:
```suggestion
public static final String READ_ADAPTIVE_SPLIT_SIZE_PARALLELISM =
"spark.sql.iceberg.read.adaptive-split-size.parallelism";
```
This matches the nesting convention already used in this file
(`executor-cache.*`, `aggregate-push-down.*`) and makes it obvious at the
config-name level that this is meaningless when
`adaptive-split-size.enabled=false`. It also pairs naturally with the existing
`SparkReadConf.parallelism()` method this overrides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
