RussellSpitzer commented on code in PR #16088:
URL: https://github.com/apache/iceberg/pull/16088#discussion_r3230220108
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkScan.java:
##########
@@ -1106,6 +1107,53 @@ public void testIncrementalScanDescription() throws
Exception {
});
}
Review Comment:
A few notes on the tests here,
1.
These don't seem to be in the right place. This class is for testing the
scan object and neither of these tests actually touch the spark scan, they are
both essentially just parsing checkings. It may be time to start a
TestSparkReadConf file for these sorts of tests
or
Actually invoke the scan here and show how the properties are changing
things.
2.
We should break out assertions, currently there are mutliple parse cases
being handled in the same test.
There should probably be somnething like
Test Adapative enabled
test Invalid parallelism
Test ...
3. Make sure we cover both the positive and negative cases. If we say a
value is invalid we should have a test throwing an error when that value is
passed.
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkScan.java:
##########
@@ -1106,6 +1107,53 @@ public void testIncrementalScanDescription() throws
Exception {
});
}
Review Comment:
A few notes on the tests here,
1.
These don't seem to be in the right place. This class is for testing the
scan object and neither of these tests actually touch the spark scan, they are
both essentially just parsing checkings. It may be time to start a
TestSparkReadConf file for these sorts of tests
or
Actually invoke the scan here and show how the properties are changing
things.
2.
We should break out assertions, currently there are mutliple parse cases
being handled in the same test.
There should probably be something like
Test Adapative enabled
test Invalid parallelism
Test ...
3. Make sure we cover both the positive and negative cases. If we say a
value is invalid we should have a test throwing an error when that value is
passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
