rdblue commented on a change in pull request #1978:
URL: https://github.com/apache/iceberg/pull/1978#discussion_r549452204
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
##########
@@ -447,10 +459,12 @@ private static void validateFlinkTable(CatalogBaseTable
table) {
if (!schema.getWatermarkSpecs().isEmpty()) {
throw new UnsupportedOperationException("Creating table with watermark
specs is not supported yet.");
}
+ }
- if (schema.getPrimaryKey().isPresent()) {
- throw new UnsupportedOperationException("Creating table with primary key
is not supported yet.");
- }
+ private static List<String> toEqualityColumns(TableSchema schema) {
Review comment:
In the format, I think that equality columns should be tracked by ID
rather than by name so that renaming columns doesn't break the primary key
metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
