rdblue commented on a change in pull request #1978:
URL: https://github.com/apache/iceberg/pull/1978#discussion_r549452415
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
##########
@@ -359,6 +363,14 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable table, boolean ig
PartitionSpec spec = toPartitionSpec(((CatalogTable)
table).getPartitionKeys(), icebergSchema);
ImmutableMap.Builder<String, String> properties = ImmutableMap.builder();
+
+ // Set the equality field columns.
+ List<String> equalityFieldColumns = toEqualityColumns(table.getSchema());
+ if (!equalityFieldColumns.isEmpty()) {
+ properties.put(TableProperties.EQUALITY_FIELD_COLUMNS,
+ org.apache.commons.lang.StringUtils.join(equalityFieldColumns, ","));
Review comment:
We try to avoid using `StringUtils` and other commons classes because we
don't want to leak the dependency. Could you use Guava's `Joiner` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
